bash-prg-hash: Initial implementation#751
Open
makavity wants to merge 20 commits intoRustCrypto:masterfrom
Open
bash-prg-hash: Initial implementation#751makavity wants to merge 20 commits intoRustCrypto:masterfrom
bash-prg-hash: Initial implementation#751makavity wants to merge 20 commits intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
I am also not sure, it should be implemented as prg-hash. |
newpavlov
reviewed
Apr 27, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Sorry for the late review!
Some preliminary comments without looking deep at the implementation and the spec.
Contributor
Author
|
Thanks for review, @newpavlov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newandnew_with_empty_headerfunctions.